Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eql? in Cask::Cask #10636

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Fix eql? in Cask::Cask #10636

merged 1 commit into from
Feb 17, 2021

Conversation

nandahkrishna
Copy link
Member

@nandahkrishna nandahkrishna commented Feb 16, 2021 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR fixes equality checking for Casks.

Before:

➜ brew livecheck volt homebrew/cask/volt
Warning: Treating volt as a formula. For the cask, use homebrew/cask/volt
Error: undefined method `token' for #<Formulary::FormulaNamespace8375643587616545a6f8955d8b01e055::Volt:0x00007ff183b86ec0>
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/cask/cask.rb:165:in `eql?'
/usr/local/Homebrew/Library/Homebrew/cli/named_args.rb:61:in `uniq'
/usr/local/Homebrew/Library/Homebrew/cli/named_args.rb:61:in `to_formulae_and_casks'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/livecheck.rb:84:in `livecheck'
/usr/local/Homebrew/Library/Homebrew/brew.rb:122:in `<main>'

After:

➜ brew livecheck volt homebrew/cask/volt
Warning: Treating volt as a formula. For the cask, use homebrew/cask/volt
volt : 0.3.7 ==> 0.3.7
volt : 0.80 ==> 0.87

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-17 at 19:50:54 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 16, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 17, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@nandahkrishna nandahkrishna merged commit c454257 into Homebrew:master Feb 17, 2021
@nandahkrishna nandahkrishna deleted the fix-cask-eql branch February 17, 2021 21:06
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 20, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nandahkrishna @BrewTestBot @MikeMcQuaid @dawidd6